[Buildbot-devel] GitHubStatus for Enterprise Users (2 problems)

[Dustin J. Mitchell]

On Fri, Jul 25, 2014 at 11:00 AM, Aran Deltac <bluefeet at gmail.com> wrote:
> I'm using GitHub Enterprise, so my API URL is not https://api.github.com,
> and neither txgithub or GitHubStatus support the ability to configure the
> API URL.
>
> I've opened a ticket for txgithub to solve this on their side:
> https://github.com/tomprince/txgithub/issues/7
>
> It should be a simple change, if I don't hear back I'll probably just make a
> pull request with the necessary changes.
>
> As for the GitHubStatus status target in buildbot I believe that would be a
> simple change to allow the user to optionally configure the API URL.  I'm
> not sure what I should do for this one as far as opening a ticket, or even
> submitting a patch (I'm a Perl developer, but I'm able to monkey together
> some Python if needed).

That would be great!  There's not a lot of spare bandwidth in the
project for working on tickets like that, but if the patch does prove
too difficult, please do at least get a bug on file.

> The GitHub status API supports a "context" field so that when you query the
> combined status it returns "failure" if any of the contexts have a failed
> status.  So, in buildbot terminology a "context" is a "builder".  I think
> GitHubStatus needs to be modified so that the context field is configurable,
> and defaults to using the builder name.

Sounds like a good bug, at least.  I don't know a whole lot about the
plugin to say whether that's easy or hard.

> I'm also concerned that even if we/I get GitHubStatus fixed up that it will
> not be released because (correct me if I'm wrong) I got the impression that
> people are trying to keep there focus on NINE and may not be open to
> releasing another 0.8.x version (I'm on 0.8.9 now).

We'll continue to support features that exist in 0.8.9, including
GitHubStatus.  @sa2ajj is maintaining the 'eight' branch, but the
policy (yet to be announced) is to only merge features that are
backported from master; in other words, no features in eight that
aren't also present in nine.

But call within the next 15 minutes, and you'll get that for free!
The GitHubStatus needs to be rewritten for nine, but that hasn't
happened yet.  So if you write a patch against 0.8.9, for a limited
time only it will apply cleanly against nine, so you get your patched
merged to two branches ABSOLUTELY FREE!  Operators are standing by.

Once we (someone, me?) rewrites GitHubStatus to use the data API, then
we'd require that any features merged to the eight branch also be
implemented (differently) for the master branch, which will be twice
the work :)

> Anyways, any thoughts on what course of action I should take would be
> appreciated.  I could just hack the code all on my end, but I'd rather this
> stuff fixed for others who use these tools.

<3 OSS!

Dustin