[Buildbot-devel] Running Pylint on Buildbot's source code

Dustin J. Mitchell dustin at v.igoro.us
Mon Jul 1 13:07:40 UTC 2013


On Mon, Jul 1, 2013 at 8:15 AM, Elmir Jagudin <elmir.jagudin at axis.com> wrote:
> What is the state of 'common/pylintrc' in buildbot's source tree? Should
> we use it as a starting point, or is better to start over?

It's pretty old, so it's probably not very useful.

> Depending on our ambition level, making "cleanup" in one step could be
> hard. Some of reported errors are trivial and can be fixed in one
> sitting. But many would require a significant effort.

True.  Note that even the 'in one sitting' fixes will need special
attention if they're done while the nine branch is still alive.

> I think a more workable approach is to start with disabling most of
> pylint checks, and then gradually fixing and enabling and more checks.

Agreed.

Dustin




More information about the devel mailing list