[Buildbot-devel] Running Pylint on Buildbot's source code

[Elmir Jagudin]

On 06/26/2013 11:10 PM, Vladimir Rutsky wrote:
> On 26.06.2013 17:34, Dustin J. Mitchell wrote:
>> On Wed, Jun 26, 2013 at 6:52 AM, Vladimir Rutsky
>> <rutsky.vladimir at gmail.com> wrote:
>>> Why Pylint usage was abandoned? It is very useful tool to keep source code
>>> visually clean.
>> We use pyflakes instead, which is a little less stringent, and focuses
>> on errors that may hide real bugs.  I know pylint is quite
>> configurable, so perhaps we could limit its scope rather severely?
>> For example, I don't care how many spaces appear before and after a {,
>> or between code and an end-of-line comment.  But I would like
>> something to check line length.
> I think it would be possible to configure Pylint to skip uninteresting
> style errors.
I have only used pylint briefly but it seems to be quite flexible, so we 
should be able to tweak it to suit our needs.

I think the first step is to decide which currently reported error we 
don't care about and which we want to eventually fix.

What is the state of 'common/pylintrc' in buildbot's source tree? Should 
we use it as a starting point, or is better to start over?
>> One more point: we've still got two long-lived branches in play -
>> master and nine.  Applying a wide-ranging "cleanup" to just one of
>> those branches will make merging a nightmare.  So, when this does come
>> to pass, the cleanup will need to be applied to master, merged to nine
>> immediately, and then re-run on nine (to catch all of the new code in
>> nine).
>>
Depending on our ambition level, making "cleanup" in one step could be 
hard. Some of reported errors are trivial and can be fixed in one 
sitting. But many would require a significant effort.

I think a more workable approach is to start with disabling most of 
pylint checks, and then gradually fixing and enabling and more checks.

/elmir