[Buildbot-devel] GitPoller fixes in 0.8.3p1

Dustin J. Mitchell dustin at v.igoro.us
Fri Jan 7 16:58:06 UTC 2011

On Fri, Jan 7, 2011 at 8:54 AM, Axel Hecht <l10n.moz at googlemail.com> wrote:
> I'm testing fcfc8840c1bef89da8d337a2c509247a86a62d5a, fwiw, but I think I
> nailed it down. Verified against master, too,

Great - thanks!

> subprocess.check_call uses the PATH environment to look for git, while I
> suspect that
> http://twistedmatrix.com/documents/10.2.0/api/twisted.internet.utils.html#getProcessOutput
> doesn't, and thus doesn't find my git binary that's in a somewhat off
> location on my mac, /usr/local/git/bin/git.

They both use the path (well, execvpe), but it looks like on Darwin
execvpe uses the PATH in the passed-in environment, while on Linux it
uses the PATH in the parent process's environment.  It's easy to fix -
replace env={} with env=dict(PATH=os.environ['PATH']) in the
getProcessOutput*() invocations.

I'll add this to the branch (and to master) and push out 0.8.3p1,
then.  Thanks for testing!

By the way, don't worry about testing master right now - it's mostly
functional, but there are some known rough edges that will be in place
until sqlalchemy is fully in place, which will be before the next


More information about the devel mailing list