[Buildbot-devel] GitPoller fixes in 0.8.3p1

Thu Jan 13 17:53:07 UTC 2011

Hi folks,

I apologize for not being on top of this thread lately - tremendously busy with some work stuff.

Anyway, I installed 0.8.3p1 last weekend and it seemed OK at first but I now realize that it has not been picking up changes. In fact, I think there is some problem with how gitpoller handles the 'workdir' setting.

This is on Mac OS X Server 10.6.6 with buildbot 0.8.3p1

The poller config looks like this:

codename_setup_git_url='ssh://username@server.sample.com/git/TeamName/Codename/codename-setup'
codename_setup_poller = GitPoller(
                    repourl= codename_setup_git_url, 
                    branch='master',
                    pollinterval = one_minute,
                    gitbin = git_bin,
                    workdir = 'codename-setup-gitpoller-workdir',
                    project = 'codename-setup',
                    )   

I see this in the twistd.log at startup:

2011-01-13 09:47:10-0800 [-] gitpoller: creating parent directories for workdir
2011-01-13 09:47:10-0800 [-] Unhandled Error
	Traceback (most recent call last):
	  File "/Library/Python/2.6/site-packages/buildbot-0.8.3p1-py2.6.egg/buildbot/master.py", line 1041, in <lambda>
	    d.addCallback(lambda res: self.loadConfig_Sources(change_sources))
	  File "/Library/Python/2.6/site-packages/buildbot-0.8.3p1-py2.6.egg/buildbot/master.py", line 1125, in loadConfig_Sources
	    d.addCallback(addNewOnes)
	  File "/Library/Python/2.6/site-packages/Twisted-8.2.0-py2.6-macosx-10.6-universal.egg/twisted/internet/defer.py", line 195, in addCallback
	    callbackKeywords=kw)
	  File "/Library/Python/2.6/site-packages/Twisted-8.2.0-py2.6-macosx-10.6-universal.egg/twisted/internet/defer.py", line 186, in addCallbacks
	    self._runCallbacks()
	--- <exception caught here> ---
	  File "/Library/Python/2.6/site-packages/Twisted-8.2.0-py2.6-macosx-10.6-universal.egg/twisted/internet/defer.py", line 328, in _runCallbacks
	    self.result = callback(self.result, *args, **kw)
	  File "/Library/Python/2.6/site-packages/buildbot-0.8.3p1-py2.6.egg/buildbot/master.py", line 1123, in addNewOnes
	    [self.change_svc.addSource(s) for s in added_sources]
	  File "/Library/Python/2.6/site-packages/buildbot-0.8.3p1-py2.6.egg/buildbot/changes/manager.py", line 70, in addSource
	    source.setServiceParent(self)
	  File "/Library/Python/2.6/site-packages/Twisted-8.2.0-py2.6-macosx-10.6-universal.egg/twisted/application/service.py", line 185, in setServiceParent
	    self.parent.addService(self)
	  File "/Library/Python/2.6/site-packages/Twisted-8.2.0-py2.6-macosx-10.6-universal.egg/twisted/application/service.py", line 305, in addService
	    service.startService()
	  File "/Library/Python/2.6/site-packages/buildbot-0.8.3p1-py2.6.egg/buildbot/changes/gitpoller.py", line 66, in startService
	    os.makedirs(dirpath)
	  File "/System/Library/Frameworks/Python.framework/Versions/2.6/lib/python2.6/os.py", line 157, in makedirs
	    mkdir(name, mode)
	exceptions.OSError: [Errno 2] No such file or directory: ''

On Jan 6, 2011, at 1:09 PM, Dustin J. Mitchell wrote:

> Axel, Matisse - or anyone else - I'd like to do this patch release,
> but I need some positive feedback first.  Can someone other than me
> give this a whirl?
> 
> Dustin
> 
> On Sat, Jan 1, 2011 at 3:35 PM, Dustin J. Mitchell <dustin at v.igoro.us> wrote:
>> The GitPoller in 0.8.3 doesn't work.  There have been a few bugs now
>> (#1745 and #1742) and several folks seeing problems in #buildbot.
>> 
>> In accordance with http://trac.buildbot.net/wiki/SupportPolicy, I'm
>> going to release 0.8.3p1 with fixes to the GitPoller.  The current
>> 'master' is unstable because of the sqlalchemy work going on there, so
>> I cannot do a fresh 0.8.4 release without rolling much of that back.
>> 
>> Before I pull the trigger on 0.8.3p1, I'd like to get feedback that
>> this is working for some of the folks who had trouble.
>> 
>> If you're using GitPoller with 0.8.3 and have been having trouble,
>> please try installing
>>  http://buildbot.net/tmp/buildbot-0.8.3-2-g15fbae9.tar.gz
>> and let me know if the situation improves for you?
>> 
>> I've tested this by throwing 1000 changes at it, and it does not run
>> out of file descriptors.  It also correctly initializes a fresh
>> repository on startup, and does not re-create it on subsequent
>> startups.
>> 
>> If there are other critical bugs with simple, shovel-ready fixes that
>> you'd like to see in 0.8.3p1, please let me know.  I don't want an
>> open season on every defect, but we have fixes available we might as
>> well ship them sooner rather than later.
>> 
>> Dustin
>> 

On Jan 1, 2011, at 1:35 PM, Dustin J. Mitchell wrote:

> The GitPoller in 0.8.3 doesn't work.  There have been a few bugs now
> (#1745 and #1742) and several folks seeing problems in #buildbot.
> 
> In accordance with http://trac.buildbot.net/wiki/SupportPolicy, I'm
> going to release 0.8.3p1 with fixes to the GitPoller.  The current
> 'master' is unstable because of the sqlalchemy work going on there, so
> I cannot do a fresh 0.8.4 release without rolling much of that back.
> 
> Before I pull the trigger on 0.8.3p1, I'd like to get feedback that
> this is working for some of the folks who had trouble.
> 
> If you're using GitPoller with 0.8.3 and have been having trouble,
> please try installing
>  http://buildbot.net/tmp/buildbot-0.8.3-2-g15fbae9.tar.gz
> and let me know if the situation improves for you?
> 
> I've tested this by throwing 1000 changes at it, and it does not run
> out of file descriptors.  It also correctly initializes a fresh
> repository on startup, and does not re-create it on subsequent
> startups.
> 
> If there are other critical bugs with simple, shovel-ready fixes that
> you'd like to see in 0.8.3p1, please let me know.  I don't want an
> open season on every defect, but we have fixes available we might as
> well ship them sooner rather than later.
> 
> Dustin