[Buildbot-devel] Change type of extraRecipients to a list....

[Marc-Antoine Ruel]

Probably a regression in MailNotifier since we run on djmitche/master.

On Thu, Nov 12, 2009 at 6:40 PM,  <chase at chromium.org> wrote:
> On 2009/11/12 23:29:04, Marc-Antoine Ruel wrote:
>>
>> the change seems strange, we were forcing a tuple previously.
>
> The Buildbot API says MailNotifier takes a tuple for extraRecipients.  I
> expect
> we were forcing tuple() before to adhere to the documentation.  But since
> Buildbot's MailNotifier calls .sort() on that variable later (and crashes
> GateKeeper this way), and MailNotifier actually verifies that
> extraRecipients is
> either a tuple or a list, the API documentation ultimately seems to be
> confused.
>
> See email I sent for more details.  It contains the full story + example
> stack
> trace.
>
>> But I trust you.
>
> Sweet.
>
>> lgtm
>
> http://codereview.chromium.org/389025
>