[Buildbot-devel] [PATCH] Fix that clobber sourcestep fails if leftover chmod 000 subdirectories (ticket#29)

[Kristian Nielsen]

Hi,

We have experienced some problems where a builder gets stuck with a failing
clobber source step that requires manual intervention to fix. This happens
when a previous build leaves a subdirectory with permissions that does not
allow the owner to delete it (eg. chmod 000).

I have seen this a number of times with the `make dist` autotools make target
in MySQL / MariaDB.

(This is ticket#29, there is a fix in the blocking code path in
slave/commands.py, but this is only used on Windows).

I have committed a patch (with unit test):

    http://github.com/knielsen/buildbot/commit/371773521a6f6f0d1f275e05f58e542f0b36d9ca

It would be great if someone could take a look and check that it looks sane.

If no objections, I will push it to trunk.

 - Kristian.