[Buildbot-devel] Build FIXED: How to notify about a build which passed when the previous build has failed?

[Marcus Lindblom]

Matisse Enzer wrote:
> On Nov 15, 2009, at 10:27 AM, Marcus Lindblom wrote:
>
>   
>> I added support to the MailNotifier to send changes only when build status changes (pass -> fail, fail -> pass, but never pass -> pass or fail -> fail).
>>
>> Nothing for IRC AFAIK, but a similar solution could be inferred from my changes:
>>
>> http://buildbot.net/trac/changeset/a421d38875b41e38d9a7a976235d80a1e9cd2415/buildbot/status/mail.py
>>     
>
> Thank for that pointer.
> Looking at it I couldn't see how to get a different notification (Mail is fine) when a build changes from fail -> pass. It is specifically the "Build FIXED" notification that I want to achieve.
>   
If mode is 'changes', the message in the mail says "The buildbot has 
detected a restored build".

Adding a change in the mail topic as well should be doable, by patching 
the subject generation line here:
http://github.com/djmitche/buildbot/blob/a421d38875b41e38d9a7a976235d80a1e9cd2415/buildbot/status/mail.py#L434
or here:
http://github.com/djmitche/buildbot/blob/a421d38875b41e38d9a7a976235d80a1e9cd2415/buildbot/status/mail.py#L478

(The line coloring is off by two in Chrome, but the numbers in the URL 
are correct)

Cheers,
/Marcus
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://buildbot.net/pipermail/devel/attachments/20091115/69aa7407/attachment.html>