[Buildbot-devel] [PATCH] 2/2: triggerable schedulers

[Dustin J. Mitchell]

On Tue, Jul 03, 2007 at 11:35:47AM -0400, Greg Ward wrote:
> Cooool.  I hope.  I'm replying before playing with the patch, which is
> probably a bad idea.  Oh well.  My only real comment right now is
> about names: I think that having a BuildStep whose name ends in
> "Scheduler" could be really confusing.  Some alternatives:
> 
>   * TriggerScheduler / TriggerStep
>     ("a TriggerStep triggers a TriggerScheduler")
> 
>   * StepDoneScheduler / TriggerStep
>     ("when a TriggerStep is done, the StepDoneSchedulers that depend
> on it fire")
> 
> I think I like the symmetry and consistent terminology of
> TriggerScheduler/TriggerStep ... but it does sort of hog the word
> "trigger" for this purpose.

I agree.  I also noticed that none of the other schedulers end in
"Scheduler", nor do steps end in "Step" so I would propose:

  * Triggerable / Trigger

What do you think?

> Anyways, on paper the design looks quite sensible to me.  I'll go see
> if I can make it work now...

Great -- let me know.

Dustin

-- 
        Dustin J. Mitchell
        Storage Software Engineer, Zmanda, Inc.
        http://www.zmanda.com/