[Buildbot-devel] [PATCH] 2/2: triggerable schedulers

[Greg Ward]

On 7/2/07, Dustin J. Mitchell <dustin at zmanda.com> wrote:
> A pair of a Scheduler and a BuildStep, where the step can "trigger"
> one or more schedulers, and optionally waits on their completion.
>
> This allows a general form of subroutine call, but is more specifically
> useful as a more powerful way to express dependent builds, particularly
> when a build must take place cooperatively among a group of builders.

Cooool.  I hope.  I'm replying before playing with the patch, which is
probably a bad idea.  Oh well.  My only real comment right now is
about names: I think that having a BuildStep whose name ends in
"Scheduler" could be really confusing.  Some alternatives:

  * TriggerScheduler / TriggerStep
    ("a TriggerStep triggers a TriggerScheduler")

  * StepDoneScheduler / TriggerStep
    ("when a TriggerStep is done, the StepDoneSchedulers that depend
on it fire")

I think I like the symmetry and consistent terminology of
TriggerScheduler/TriggerStep ... but it does sort of hog the word
"trigger" for this purpose.

Anyways, on paper the design looks quite sensible to me.  I'll go see
if I can make it work now...

Thanks!

Greg