[Buildbot-devel] Use names instead of content for shell commands

Niklaus Giger Niklaus.Giger at netstal.com
Wed Apr 12 08:40:46 UTC 2006


On http://ngiger.dyndns.org/buildbot/ for the Xenomai project
I patched buildbot like this:

 looking for arch at buildbot.sf.net--2004/buildbot--dev--0--patch-487 to compare
* comparing to arch at buildbot.sf.net--2004/buildbot--dev--0--patch-487: . done.

* modified files

--- orig/buildbot/status/html.py
+++ mod/buildbot/status/html.py
@@ -942,7 +942,7 @@
             urllib.quote(b.getBuilder().getName(), safe=''),
             urllib.quote(self.original.getName(), safe=''))
-        text = self.original.getText()
+	text = [self.original.getName()]
         if text is None:
             log.msg("getText() gave None", urlbase)
             text = []

Now I get for my shell commands names like "configure_kernel" instead
of the the (way too long)  command. However if I put a space into the name of
my shell script as in "prepare slave" it resolves to a HTTP reference like

Before digging too long into the source code to generate a test case and fix
the errors, I would like to ask, whether this change would be welcomed.

Best regards

Niklaus Giger

More information about the devel mailing list