[Buildbot-devel] Use names instead of content for shell commands

[Alexander Lorenz]

hello,


maybe i'm just overlooking something, but what advantage does this 
solution have over just setting the 'description' and 'descriptiondone' 
properties of a buildstep?



regards

lx



Niklaus Giger wrote:
> Hi
>
> On http://ngiger.dyndns.org/buildbot/ for the Xenomai project
> I patched buildbot like this:
>
>  looking for arch at buildbot.sf.net--2004/buildbot--dev--0--patch-487 to compare
> with
> * comparing to arch at buildbot.sf.net--2004/buildbot--dev--0--patch-487: . done.
>
> * modified files
>
> --- orig/buildbot/status/html.py
> +++ mod/buildbot/status/html.py
> @@ -942,7 +942,7 @@
>              urllib.quote(b.getBuilder().getName(), safe=''),
>              b.getNumber(),
>              urllib.quote(self.original.getName(), safe=''))
> -        text = self.original.getText()
> +	text = [self.original.getName()]
>          if text is None:
>              log.msg("getText() gave None", urlbase)
>              text = []
>
> Now I get for my shell commands names like "configure_kernel" instead
> of the the (way too long)  command. However if I put a space into the name of
> my shell script as in "prepare slave" it resolves to a HTTP reference like
> http://ngiger.dyndns.org/buildbot/tqm860/builds/6/step-prepare%20buildbot/0
>
> Before digging too long into the source code to generate a test case and fix
> the errors, I would like to ask, whether this change would be welcomed.
>
> Best regards
>
> Niklaus Giger
>
>
>
> -------------------------------------------------------
> This SF.Net email is sponsored by xPML, a groundbreaking scripting language
> that extends applications into web and mobile media. Attend the live webcast
> and join the prime developer group breaking into this new coding territory!
> http://sel.as-us.falkag.net/sel?cmd=lnk&kid=110944&bid=241720&dat=121642
> _______________________________________________
> Buildbot-devel mailing list
> Buildbot-devel at lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/buildbot-devel
>
>