[Buildbot-commits] [Buildbot] #2696: (PostgreSQL) missing rollback in db.scheduler

[Buildbot trac]

#2696: (PostgreSQL) missing rollback in db.scheduler
---------------------+------------------------
Reporter:  gracinet  |       Owner:
    Type:  defect    |      Status:  new
Priority:  major     |   Milestone:  undecided
 Version:  master    |  Resolution:
Keywords:            |
---------------------+------------------------

Comment (by gracinet):

 A quickfix is at
 https://github.com/gracinet/buildbot/commit/c9289275452555f96db2aa1edd8e2824f34e85dc

 Contrary to what the commit message says, the transactional behaviour with
 the quickfix is suboptimal (the transaction is about several changeset,
 one failed insert should not rollback the others).

 A better version would be to check for prior existence and update or
 insert accordingly, but I'll have to dig a bit further to know what this
 is about really.

 savepoints would be an option, but I'm not sure all RDMS provide them
 (does SQLite ? ) IIRC, they're not even exposed in an abstract API by
 psycopg2.

-- 
Ticket URL: <http://trac.buildbot.net/ticket/2696#comment:1>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation