[Buildbot-commits] [Buildbot] #2696: (PostgreSQL) missing rollback in db.scheduler

[Buildbot trac]

#2696: (PostgreSQL) missing rollback in db.scheduler
---------------------+------------------------
Reporter:  gracinet  |       Owner:
    Type:  defect    |      Status:  new
Priority:  major     |   Milestone:  undecided
 Version:  master    |  Resolution:
Keywords:            |
---------------------+------------------------

Comment (by dustin):

 Checking and then inserting introduces a race condition - that's what
 we're trying to avoid with this logic.

 It's OK to introduce DB-specific behavior in the DB modules, if there's a
 need to.

 Is it automatic that when an insert fails, Postgres aborts the whole
 transaction?  Or is that something automatic that's happening on the
 client?  In my testing with postgres, this works fine (the
 buildbot.test.unit.test_db_schedulers.TestSchedulersConnectorComponent.test_classifyChanges_again
 executes this particular except block)

-- 
Ticket URL: <http://trac.buildbot.net/ticket/2696#comment:2>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation