[Buildbot-commits] [Buildbot] #2696: (PostgreSQL) missing rollback in db.scheduler

[Buildbot trac]

#2696: (PostgreSQL) missing rollback in db.scheduler
---------------------+-----------------------
Reporter:  gracinet  |      Owner:
    Type:  defect    |     Status:  new
Priority:  major     |  Milestone:  undecided
 Version:  master    |   Keywords:
---------------------+-----------------------
 Main symptom:

 {{{
           File "/srv/buildbot/local/lib/python2.7/site-
 packages/sqlalchemy/engin
 e/base.py", line 1690, in _execute_context
             context)
           File "/srv/buildbot/local/lib/python2.7/site-
 packages/sqlalchemy/engin
 e/default.py", line 335, in do_execute
             cursor.execute(statement, parameters)
         sqlalchemy.exc.InternalError: (InternalError) current transaction
 is aborted, commands ignored until end of transaction block
          'UPDATE scheduler_changes SET important=%(important)s WHERE
 scheduler_changes.objectid = %(objectid_1)s AND scheduler_changes.changeid
 = %(wc_changeid)s' {'wc_changeid': 5096, 'important': 1, 'objectid_1': 15}
 }}}

 This excerpt from ```db.schedulers``` cannot work with PostgreSQL:

 {{{
                 except (sqlalchemy.exc.ProgrammingError,
                         sqlalchemy.exc.IntegrityError):
                     # insert failed, so try an update
                     conn.execute(upd_q,
 }}}

 Indeed, after either of these two exceptions, the transaction must be
 rollbacked.

-- 
Ticket URL: <http://trac.buildbot.net/ticket/2696>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation