[Buildbot-commits] [buildbot/buildbot] 549b70: Remove test_describe_fail() and add tests for desc...

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/buildbot/buildbot
  Commit: 549b70b3e37565e8aa5d0036283b47452e72dbec
      https://github.com/buildbot/buildbot/commit/549b70b3e37565e8aa5d0036283b47452e72dbec
  Author: Vladimir Rutsky <altsysrq at gmail.com>
  Date:   2013-11-16 (Sat, 16 Nov 2013)

  Changed paths:
    M master/buildbot/test/unit/test_steps_shell.py

  Log Message:
  -----------
  Remove test_describe_fail() and add tests for describe() on custom rendarables

_describe() checks with:

   try:
       len(words)
   except AttributeError:
       # WithProperties and Property don't have __len__
       return ["???"]

if passed command is some kind of rendarable, so describe() should never fail.

But this doesn't work for renderables which are instances of new-style
classes - add failing tests for that cases.


  Commit: 484dc57b7b9c9f600dd0ea8e64d507992a14f020
      https://github.com/buildbot/buildbot/commit/484dc57b7b9c9f600dd0ea8e64d507992a14f020
  Author: Vladimir Rutsky <altsysrq at gmail.com>
  Date:   2013-11-16 (Sat, 16 Nov 2013)

  Changed paths:
    M master/buildbot/steps/shell.py

  Log Message:
  -----------
  Fix _describe() when command is new-style class instance


  Commit: b8d88f0671f8a18c2e82cfafcd2f075f9218989e
      https://github.com/buildbot/buildbot/commit/b8d88f0671f8a18c2e82cfafcd2f075f9218989e
  Author: Dustin J. Mitchell <dustin at mozilla.com>
  Date:   2013-11-17 (Sun, 17 Nov 2013)

  Changed paths:
    M master/buildbot/steps/shell.py
    M master/buildbot/test/unit/test_steps_shell.py

  Log Message:
  -----------
  Merge branch 'fix_custom_renderables_describe' of git://github.com/vrutsky/buildbot


Compare: https://github.com/buildbot/buildbot/compare/93447bbef41d...b8d88f0671f8