[Buildbot-commits] [Buildbot] #2587: Buildbot doesn't accept changes done by the same user for different repositories

[Buildbot trac]

#2587: Buildbot doesn't accept changes done by the same user for different
repositories
---------------------------+--------------------
Reporter:  jollyroger      |       Owner:
    Type:  defect          |      Status:  new
Priority:  major           |   Milestone:  0.8.9
 Version:  0.8.8           |  Resolution:
Keywords:  database users  |
---------------------------+--------------------
Changes (by dustin):

 * milestone:  undecided => 0.8.9


Comment:

 In more detail:
  * when the first user, git in this case, is added, it defaults to using
 the full git username as the identifier
  * when the second user is added, svn in this case, the lookup in the
 `users_info` table doesn't find the existing record, because the
 `attr_type` column differs.
  * consequently, it attempts to add a new, unrelated user, although one
 that the admin may later want to join to the existing user
  * that new, unrelated user also uses the full username <email> pair as
 the identifier, but it happens that's already taken.

 I can see cases where it will obviously make sense to merge users when
 this happens.  But I can also see cases where it won't (e.g., Dustin
 Sallings and I are 'dustin' on various services like github and
 sourceforge, and we wouldn't want our accounts combined).  So I think that
 the best thing to do is take the safe default, and when identifiers clash,
 add some suffix to disambiguate them, e.g., `'User Name (1)
 <user_name at example.com>'`.

-- 
Ticket URL: <http://trac.buildbot.net/ticket/2587#comment:1>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation