[Buildbot-commits] [buildbot/buildbot] 0a6063: Force types on 'log-size' and 'log-count' argument...

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/buildbot/buildbot
  Commit: 0a6063c54565dc7806bedb87d74c419e59805ae0
      https://github.com/buildbot/buildbot/commit/0a6063c54565dc7806bedb87d74c419e59805ae0
  Author: Vladimir Rutsky <altsysrq at gmail.com>
  Date:   2013-11-16 (Sat, 16 Nov 2013)

  Changed paths:
    M master/buildbot/scripts/buildbot_tac.tmpl
    M master/buildbot/scripts/runner.py
    M master/buildbot/test/unit/test_scripts_create_master.py
    M master/buildbot/test/unit/test_scripts_runner.py

  Log Message:
  -----------
  Force types on 'log-size' and 'log-count' arguments for "create-master" command

Previously these arguments were treated as string and passed as strings to
twisted.python.logfile.LogFile.fromFullPath() in buildbot.tac:

rotateLength = '10000000'
maxRotatedFiles = '10'


That led to invalid behaviour of Twisted logger - logs doesn't rotated at all.


  Commit: 034e4099fd0d5667a36ad6d605612366f06f1e93
      https://github.com/buildbot/buildbot/commit/034e4099fd0d5667a36ad6d605612366f06f1e93
  Author: Vladimir Rutsky <altsysrq at gmail.com>
  Date:   2013-11-16 (Sat, 16 Nov 2013)

  Changed paths:
    M master/buildbot/test/unit/test_scripts_create_master.py

  Log Message:
  -----------
  Add tests to check correct 'log-size' and 'log-count' formatting


  Commit: 37238a75fe9e9ee2aacc3268466b534febdae711
      https://github.com/buildbot/buildbot/commit/37238a75fe9e9ee2aacc3268466b534febdae711
  Author: Vladimir Rutsky <altsysrq at gmail.com>
  Date:   2013-11-16 (Sat, 16 Nov 2013)

  Changed paths:
    M master/buildbot/test/unit/test_scripts_create_master.py

  Log Message:
  -----------
  Check only for exception type when checking for Jinja error

Travis version on Jinja has "an integer is required" exception text,
lets not rely on it.


  Commit: e3923d992ca9eb83cd36ca771c7ba6fcb1b1dbd8
      https://github.com/buildbot/buildbot/commit/e3923d992ca9eb83cd36ca771c7ba6fcb1b1dbd8
  Author: Vladimir Rutsky <altsysrq at gmail.com>
  Date:   2013-11-16 (Sat, 16 Nov 2013)

  Changed paths:
    M master/buildbot/test/unit/test_scripts_runner.py

  Log Message:
  -----------
  Fix broken scripts.runner tests


  Commit: 95b0661b3fd8ea782fc4bb2341e6c429ccb418d4
      https://github.com/buildbot/buildbot/commit/95b0661b3fd8ea782fc4bb2341e6c429ccb418d4
  Author: Vladimir Rutsky <altsysrq at gmail.com>
  Date:   2013-11-16 (Sat, 16 Nov 2013)

  Changed paths:
    M master/buildbot/test/unit/test_scripts_runner.py

  Log Message:
  -----------
  Add test for case when "log-count" is None


  Commit: 5fb3d689c6d96ecd19ae986459ae8767b486d8a0
      https://github.com/buildbot/buildbot/commit/5fb3d689c6d96ecd19ae986459ae8767b486d8a0
  Author: Vladimir Rutsky <altsysrq at gmail.com>
  Date:   2013-11-16 (Sat, 16 Nov 2013)

  Changed paths:
    M master/buildbot/scripts/runner.py

  Log Message:
  -----------
  Remove unused import of 're' module

Strange that pyflakes reported about this only now:
<https://travis-ci.org/vrutsky/buildbot/jobs/14080064>
and doesn't report eralier, e.g.
<https://travis-ci.org/vrutsky/buildbot/jobs/14080076>,
with same pyflakes v0.7.3...


  Commit: 2ec5af75d6db9779183536b36690d6c2e0b652cc
      https://github.com/buildbot/buildbot/commit/2ec5af75d6db9779183536b36690d6c2e0b652cc
  Author: Dustin J. Mitchell <dustin at mozilla.com>
  Date:   2013-11-17 (Sun, 17 Nov 2013)

  Changed paths:
    M master/buildbot/scripts/buildbot_tac.tmpl
    M master/buildbot/scripts/runner.py
    M master/buildbot/test/unit/test_scripts_create_master.py
    M master/buildbot/test/unit/test_scripts_runner.py

  Log Message:
  -----------
  Merge branch 'fix_create_master_log_params' of git://github.com/vrutsky/buildbot


Compare: https://github.com/buildbot/buildbot/compare/b8d88f0671f8...2ec5af75d6db