[Buildbot-commits] buildbot ChangeLog,1.465,1.466

Brian Warner warner at users.sourceforge.net
Tue Jul 19 19:49:38 UTC 2005


Update of /cvsroot/buildbot/buildbot
In directory sc8-pr-cvs1.sourceforge.net:/tmp/cvs-serv31532

Modified Files:
	ChangeLog 
Log Message:
Revision: arch at buildbot.sf.net--2004/buildbot--dev--0--patch-237
Creator:  Brian Warner <warner at lothar.com>

don't use open(mode="wt+") to fix OS-X problem, other small fixes

	* docs/buildbot.texinfo (@settitle): don't claim version 1.0

	* buildbot/changes/mail.py (parseSyncmail): update comment

	* buildbot/test/test_slavecommand.py: disable Shell tests on
	platforms that don't suport IReactorProcess

	* buildbot/status/builder.py (LogFile): remove the 't' mode from
	all places where we open logfiles. It causes OS-X to open the file
	in some weird mode that that prevents us from mixing reads and
	writes to the same filehandle, which we depend upon to implement
	_generateChunks properly. This change doesn't appear to break
	win32, on which "b" and "t" are treated differently but a missing
	flag seems to be interpreted as "t".


Index: ChangeLog
===================================================================
RCS file: /cvsroot/buildbot/buildbot/ChangeLog,v
retrieving revision 1.465
retrieving revision 1.466
diff -u -d -r1.465 -r1.466
--- ChangeLog	19 Jul 2005 01:55:21 -0000	1.465
+++ ChangeLog	19 Jul 2005 19:49:35 -0000	1.466
@@ -1,3 +1,20 @@
+2005-07-19  Brian Warner  <warner at lothar.com>
+
+	* docs/buildbot.texinfo (@settitle): don't claim version 1.0
+
+	* buildbot/changes/mail.py (parseSyncmail): update comment
+
+	* buildbot/test/test_slavecommand.py: disable Shell tests on
+	platforms that don't suport IReactorProcess
+
+	* buildbot/status/builder.py (LogFile): remove the 't' mode from
+	all places where we open logfiles. It causes OS-X to open the file
+	in some weird mode that that prevents us from mixing reads and
+	writes to the same filehandle, which we depend upon to implement
+	_generateChunks properly. This change doesn't appear to break
+	win32, on which "b" and "t" are treated differently but a missing
+	flag seems to be interpreted as "t".
+
 2005-07-18  Brian Warner  <warner at lothar.com>
 
 	* buildbot/slave/commands.py (ShellCommand): overhaul





More information about the Commits mailing list