[Buildbot-commits] buildbot/buildbot/test test_slavecommand.py,1.15,1.16

Brian Warner warner at users.sourceforge.net
Tue Jul 19 19:49:38 UTC 2005

Update of /cvsroot/buildbot/buildbot/buildbot/test
In directory sc8-pr-cvs1.sourceforge.net:/tmp/cvs-serv31532/buildbot/test

Modified Files:
Log Message:
Revision: arch at buildbot.sf.net--2004/buildbot--dev--0--patch-237
Creator:  Brian Warner <warner at lothar.com>

don't use open(mode="wt+") to fix OS-X problem, other small fixes

	* docs/buildbot.texinfo (@settitle): don't claim version 1.0

	* buildbot/changes/mail.py (parseSyncmail): update comment

	* buildbot/test/test_slavecommand.py: disable Shell tests on
	platforms that don't suport IReactorProcess

	* buildbot/status/builder.py (LogFile): remove the 't' mode from
	all places where we open logfiles. It causes OS-X to open the file
	in some weird mode that that prevents us from mixing reads and
	writes to the same filehandle, which we depend upon to implement
	_generateChunks properly. This change doesn't appear to break
	win32, on which "b" and "t" are treated differently but a missing
	flag seems to be interpreted as "t".

Index: test_slavecommand.py
RCS file: /cvsroot/buildbot/buildbot/buildbot/test/test_slavecommand.py,v
retrieving revision 1.15
retrieving revision 1.16
diff -u -d -r1.15 -r1.16
--- test_slavecommand.py	19 Jul 2005 01:55:20 -0000	1.15
+++ test_slavecommand.py	19 Jul 2005 19:49:36 -0000	1.16
@@ -1,7 +1,7 @@
 # -*- test-case-name: buildbot.test.test_slavecommand -*-
 from twisted.trial import unittest
-from twisted.internet import reactor
+from twisted.internet import reactor, interfaces
 from twisted.python import util, runtime, failure
 from buildbot.twcompat import maybeWait
@@ -252,7 +252,12 @@
         # seconds. I assume that the win32eventreactor is waiting for one of
         # the lingering child processes to really finish.
+haveProcess = interfaces.IReactorProcess(reactor, None)
 if runtime.platformType == 'posix':
     # test with PTYs also
     class ShellPTY(ShellBase, unittest.TestCase):
         usePTY = True
+    if not haveProcess:
+        ShellPTY.skip = "this reactor doesn't support IReactorProcess"
+if not haveProcess:
+    Shell.skip = "this reactor doesn't support IReactorProcess"

More information about the Commits mailing list