[Buildbot-commits] buildbot/buildbot/changes mail.py,1.19,1.20

Brian Warner warner at users.sourceforge.net
Tue Jul 19 19:49:38 UTC 2005

Update of /cvsroot/buildbot/buildbot/buildbot/changes
In directory sc8-pr-cvs1.sourceforge.net:/tmp/cvs-serv31532/buildbot/changes

Modified Files:
Log Message:
Revision: arch at buildbot.sf.net--2004/buildbot--dev--0--patch-237
Creator:  Brian Warner <warner at lothar.com>

don't use open(mode="wt+") to fix OS-X problem, other small fixes

	* docs/buildbot.texinfo (@settitle): don't claim version 1.0

	* buildbot/changes/mail.py (parseSyncmail): update comment

	* buildbot/test/test_slavecommand.py: disable Shell tests on
	platforms that don't suport IReactorProcess

	* buildbot/status/builder.py (LogFile): remove the 't' mode from
	all places where we open logfiles. It causes OS-X to open the file
	in some weird mode that that prevents us from mixing reads and
	writes to the same filehandle, which we depend upon to implement
	_generateChunks properly. This change doesn't appear to break
	win32, on which "b" and "t" are treated differently but a missing
	flag seems to be interpreted as "t".

Index: mail.py
RCS file: /cvsroot/buildbot/buildbot/buildbot/changes/mail.py,v
retrieving revision 1.19
retrieving revision 1.20
diff -u -d -r1.19 -r1.20
--- mail.py	18 May 2005 07:49:29 -0000	1.19
+++ mail.py	19 Jul 2005 19:49:36 -0000	1.20
@@ -114,7 +114,9 @@
     subject = m.getheader("subject")
     # syncmail puts the repository-relative directory in the subject:
-    # "%(dir)s %(file)s,%(oldversion)s,%(newversion)s"
+    # mprefix + "%(dir)s %(file)s,%(oldversion)s,%(newversion)s", where
+    # 'mprefix' is something that could be added by a mailing list
+    # manager.
     # this is the only reasonable way to determine the directory name
     space = subject.find(" ")
     if space != -1:

More information about the Commits mailing list