[Buildbot] #3482: remove master logic from slave/buildslave/scripts/logwatcher.py or unify implementation in master and worker

Buildbot trac trac at buildbot.net
Mon Mar 14 09:54:47 UTC 2016


#3482: remove master logic from slave/buildslave/scripts/logwatcher.py or unify
implementation in master and worker
----------------------+-----------------------
Reporter:  rutsky     |      Owner:
    Type:  undecided  |     Status:  new
Priority:  major      |  Milestone:  undecided
 Version:  master     |   Keywords:
----------------------+-----------------------
 `logwatcher.py` in `master` and `slave` source directories are almost
 same, but `logwatcher.py` in `slave` has logic which should made
 `logwatcher.py` to be usable in master and worker implementations.

 I think we should:

 1) either remove "master" logic from `logwatcher.py` in worker code and
 treat `logwatcher.py` in master and worker as independed modules.

 2) or use exactly same `logwatcher.py` in master and worker sources, with
 support of master and worker logic.

 What approach is better?

--
Ticket URL: <http://trac.buildbot.net/ticket/3482>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation


More information about the bugs mailing list