[Buildbot] #3482: remove master logic from slave/buildslave/scripts/logwatcher.py or unify implementation in master and worker
Buildbot trac
trac at buildbot.net
Mon Mar 14 10:15:47 UTC 2016
#3482: remove master logic from slave/buildslave/scripts/logwatcher.py or unify
implementation in master and worker
----------------------+------------------------
Reporter: rutsky | Owner:
Type: undecided | Status: new
Priority: major | Milestone: undecided
Version: master | Resolution:
Keywords: |
----------------------+------------------------
Comment (by rutsky):
BTW, this line is incorrect for about 5 years:
https://github.com/buildbot/buildbot/blob/4d733e6/slave/buildslave/scripts/logwatcher.py#L125
{{{
if "Creating BuildSlave" in line:
self.processtype = "buildslave"
}}}
(since [https://github.com/buildbot/buildbot/commit/34ee2484 this
commit]), and `logwatcher.py` in worker generates
`BuildmasterTimeoutError` instead `BuildslaveTimeoutError`, but this
doesn't bother anyone, because both exceptions are handled in worker code:
https://github.com/buildbot/buildbot/blob/4d733e62d5570fdb9e603ebfeb333899bdb1f710/slave/buildslave/scripts/start.py#L47
--
Ticket URL: <http://trac.buildbot.net/ticket/3482#comment:1>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation
More information about the bugs
mailing list