[users at bb.net] Expected test failures?

[Dan Kegel]

Hi all!  I followed
http://docs.buildbot.net/current/developer/tests.html#quick-start
to check out the code and run the self-tests on Ubuntu 18.04,
using python 3.6 (since that's what is installed by default)
and the master branch of buildbot.
The steps I had to follow are slightly different from that recipe:

sudo apt install virtualenv enchant
git clone https://github.com/buildbot/buildbot
cd buildbot
make virtualenv VENV_PY_VERSION=python3.6
. .venvpython3.6/bin/activate
trial buildbot
...
Ran 5263 tests in 154.628s
FAILED (skips=27, errors=43, successes=5234)

42 of the failures can be reproduced with

trial \
      buildbot.test.unit.test_schedulers_triggerable \
      buildbot.test.unit.test_steps_http \
      buildbot.test.unit.test_util_httpclientservice \
      buildbot.test.unit.test_www_service

To see if it's the python version, I tried

sudo apt install python2.7-dev
make virtualenv VENV_PY_VERSION=python2.7
. .venvpython2.7/bin/activate
trial buildbot
...
Ran 5263 tests in 134.589s
FAILED (skips=25, errors=43, successes=5236)

So it's not the python. Are these failures expected?

One recurring issue was

Traceback (most recent call last):
  File "/home/buildbot/src/buildbot/master/buildbot/test/unit/test_www_service.py",
line 273, in test_updateSession
    request = Request(FakeChannel(), False)
  File "/home/buildbot/src/buildbot/.venvpython2.7/local/lib/python2.7/site-packages/twisted/web/server.py",
line 116, in __init__
    http.Request.__init__(self, *args, **kw)
  File "/home/buildbot/src/buildbot/.venvpython2.7/local/lib/python2.7/site-packages/twisted/web/http.py",
line 727, in __init__
    self.client = self.channel.getPeer()
exceptions.AttributeError: 'FakeChannel' object has no attribute 'getPeer'

(Oddly, doing trial \
      buildbot.test.unit.test_schedulers_triggerable \
      buildbot.test.unit.test_steps_http \
      buildbot.test.unit.test_util_httpclientservice \
      buildbot.test.unit.test_www_service
with python 2.7 yielded 53 errors; go figure.)