[devel at bb.net] ticket 2887 & 3270

[Edmund Wong]

Dustin J. Mitchell wrote:
> On Wed, Apr 6, 2016 at 5:05 AM, Edmund Wong <ewongbb at pw-wspx.org> wrote:
> 
>> I've taken a look at the list of possible events and am
>> not sure which ones Buildbot (wrt ticket 2887) would
>> care about (well aside for the 'create' branch/tag,
>> which buildbot should try to do a build on the
>> created branch).
>>
> 
> I'd way we should expose all of them, and let users pick the things they're
> interested in.

I'm currently playing around with Github's webhooks and api.

As for exposing all of them, I'm wondering how to implement each
of the reactions to the webhooks.  :anish told me about the pr
comment (i.e. @rebuild) and I'm working on that; but what
about other items?  I 'possibly' understand the webhooks;
but I probably don't understand how to implement these.

Like if an issue is created, what needs to be done by buildbot?

I'm sorry to be so dense.

Edmund
> 
> Yes, but that's not enough.  As someone with a buildbot worker in my
> basement, I don't want anyone on github to be able to run code on that
> worker.  I trust the Buildbot committers enough to test code after it has
> been reviewed, but not before.  So Buildbot needs some way to "approve" a
> pull request for buliding.

Good point.  I'm not quite sure how to go about in achieving this
security though.

> 
> It also needs some way to report the status of that back to the github pull
> request -- there's really no point in building it if nobody sees the
> results.

However, this I think I've managed to figure out.  I just need to do
some prelim. testing.

Edmund