[devel at bb.net] ticket 2887 & 3270
Dustin J. Mitchell
dustin at v.igoro.us
Wed Apr 6 13:57:17 UTC 2016
On Wed, Apr 6, 2016 at 5:05 AM, Edmund Wong <ewongbb at pw-wspx.org> wrote:
> I've taken a look at the list of possible events and am
> not sure which ones Buildbot (wrt ticket 2887) would
> care about (well aside for the 'create' branch/tag,
> which buildbot should try to do a build on the
> created branch).
>
I'd way we should expose all of them, and let users pick the things they're
interested in.
> As for ticket 3270, I'm somewhat confused (probably because
> my understanding is still lacking). With the github
> pull_request handler in the github hook, wouldn't buildbot
> already be set to test the pull requests?
>
Yes, but that's not enough. As someone with a buildbot worker in my
basement, I don't want anyone on github to be able to run code on that
worker. I trust the Buildbot committers enough to test code after it has
been reviewed, but not before. So Buildbot needs some way to "approve" a
pull request for buliding.
It also needs some way to report the status of that back to the github pull
request -- there's really no point in building it if nobody sees the
results.
Dustin
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.buildbot.net/pipermail/devel/attachments/20160406/caa31117/attachment.html>
More information about the devel
mailing list