[Buildbot-devel] git retry not working on timeout?

[Vitali Lovich]

Hi,

I’m having a problem where my git step hangs due to some kind of network or server issue.
I have a timeout value of 30s so that if we’re not getting output from the server we don’t wait forever.

I also have retryFetch=True and retry=(1, 5) set but it doesn’t look like buildbot is retrying.
Looking at the code it would seem like the retry should be applied even on timeout, but I can’t find what’s going wrong.

Thanks,
Vitali

Here’s the redacted log for the step:
git --version
 in dir /private/var/buildbot/slaves/workdir/Feature_Test_Request/../mirror/project (timeout 30 secs)
 watching logfiles {}
 argv: ['git', '--version']
 using PTY: False
git version 2.2.1
program finished with exit code 0
elapsedTime=0.163473
stat: No such file or directory: /private/var/buildbot/slaves/workdir/Feature_Test_Request/../mirror/project/.buildbot-patchedprogram finished with exit code 2
program finished with exit code 0
git cat-file -e f3bfa8c5c72af0337577bb9ebf111cb24edcc312
 in dir /private/var/buildbot/slaves/workdir/Feature_Test_Request/../mirror/project (timeout 30 secs)
 watching logfiles {}
 argv: ['git', 'cat-file', '-e', 'f3bfa8c5c72af0337577bb9ebf111cb24edcc312']
 using PTY: False
program finished with exit code 1
elapsedTime=2.012485
git fetch -t git at gitlab.<redacted>:<redacted>/project.git <branch> --progress
 in dir /private/var/buildbot/slaves/workdir/Feature_Test_Request/../mirror/project (timeout 30 secs)
 watching logfiles {}
 argv: ['git', 'fetch', '-t', 'git at gitlab.<redacted>:<redacted>/project.git', ‘<branch>', '--progress']
 using PTY: False

command timed out: 30 seconds without output running ['git', 'fetch', '-t', 'git at gitlab.<redacted>:<redacted>/project.git', ‘<branch>', '--progress'], attempting to kill
process killed by signal 9
program finished with exit code -1
elapsedTime=30.152976