[Buildbot-devel] PerlModuleTest ignores warnOnFailure

[Mikhail Sobolev]

Hi Aran,

On Thu, Apr 09, 2015 at 09:32:19PM +0000, Aran Deltac wrote:
>    Thanks for digging in!
>    For Buildbot nine might I suggest calling this buildbot step TAPTest
>    instead of PerlModuleTest?  TAP isn't Perl-specific anymore.  I'm using
>    it with node for example.  :)
I checked the PerlModuleTest and the behaviour that is expected[1].
PerlModuleTest does not anything special beside returning the step status
according to the test results.

The options now are:
* to make sure that buildmaster is reconfigured (even better restarted)
* check parameters
* check logs and step status

As for the renaming step, this sounds like a good idea except that
PerlModuleTest has a default command to execute and it's not really clear what
would be the command in general TAP case.  I personally like the idea of the
rename and am inclined to add a couple of lines into the documentation saying
that by default the perl 'prove' command will be executed.

I'd appreciate if the table[1] is reviewed and if it looks feasible, I'll
submit a PR to the current docs.

-- 
Misha

[1] http://trac.buildbot.net/wiki/BuildStepParams