[Buildbot-devel] rotateLogs issue

Dustin J. Mitchell dustin at v.igoro.us
Tue Sep 17 01:17:21 UTC 2013


I think that the right fix is to make sure that the values are passed
to the template as integers, so that the repr appears correctly.

As for tests: yes, rotation is primarily a Twisted function, and a
test that would catch this kind of problem would be fiendishly
difficult to devise - just parsing buildbot.tac isn't enough.

It may make sense to add this as a small fix and test in Twisted
itself: check the type of the parameters and fail more loudly if they
are not integers.  That's strictly extra-credit, though, and I'm not
sure that bug would be accepted upstream.

Dustin




More information about the devel mailing list