[Buildbot-devel] rotateLogs issue

[John Wieland]

I've noticed an issue with rotateLength and maxRotatedFiles in the
buildbot.tac being strings in the buildmaster buildbot.tac. This causes
issues in the log comparison code because it is attempting to compare a
string to an integer in twistd LogFile. Changing the two variables to be
integers in a deployment resolves the issue and logs begin being rotated.

The issue appears to be caused by using the repr filter in the template
when generating the tac file. This is easily fixed by removing the filter.
I've written a unit test to confirm that the tac is generated correctly,
similar to the other makeTAC tests in the test_scripts_create_master.py and
could submit a pull request. However, I'm currently wondering if it is
worth implementing some regression tests to confirm the log rotation is
working correctly? Or are there some already? It seems to me as though log
rotation is twisted functionality.

Cheers,
John
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://buildbot.net/pipermail/devel/attachments/20130913/a4a3597c/attachment.html>