[Buildbot-devel] sqlalchemy putting several operations into transactions

[Dustin J. Mitchell]

Yes, what we've done in nine is to add sha1 hashes of long items, and
made the unique index cover the sha1 hash.

Scheduler names are an example:
  https://github.com/buildbot/buildbot/blob/nine/master/buildbot/db/model.py#L404

What we haven't done yet is to actually limit the length and character
sets of items that might appear in URLs (builder names, for example).

We're not accepting any more DB migrations in the 0.8.x branch, but of
course you're welcome to make local customizations yourself.

Dustin

On Mon, Nov 25, 2013 at 4:06 AM, Maria Marcano
<mariangemarcano at gmail.com> wrote:
>
> where is the InnoDB fix?, is it already apply to nine branch (I'm seeing for
> example buildrequests table with sa.String
> length=256
> https://github.com/buildbot/buildbot/blob/nine/master/buildbot/db/model.py#L58
>
> is it something that could be apply also on version 0.8.x ? the
> customizations I'm working are based on this version,
>
>> We're working toward a situation in nine where we can use InnoDB, by
>> eliminating the use of unbounded-length strings in indexes.
>
>
>
>>
>> That said, it can be set on a per-table basis, so it's probably enough
>> to set it on the tables which support -- most, I think -- it in the
>> nine branch.  Do you want to make up a patch to do so, including a
>> migration script?  The script would be a no-op on anything other than
>> MySQL.
>>
>> Dustin
>
>
> Yes once I've it working on version 0.8. I can submit a patch for nine as
> well.
>
> Thanks Maria.
>