[Buildbot-devel] Use of Interpolate in git source step

[Amber Yust]

+Andrew explicitly.


On Mon, Nov 4, 2013 at 9:08 PM, Amber Yust <amber.yust at gmail.com> wrote:

> Dustin, the issue is being triggered here:
>
> https://github.com/buildbot/buildbot/blob/buildbot-0.8.8/master/buildbot/steps/source/git.py#L313
>
> The proximate cause of the problem is that the implementation of the Git
> source step in 0.8.8 assumes that the command is a list of basic strings
> such that they can be .join()'d together for a log message. This of course
> fails if the command includes any Interpolate or WithProperties instances.
>
> As far as I can tell, this has been a problem since 2011 when the
> rewritten Git source step was introduced; that line blames all the way to
> 9b032e6a<https://github.com/buildbot/buildbot/commit/9b032e6ac17575841032c3a3c8a0def5da7fe569>,
> and would definitely prevent any non-string values in the parameters which
> eventually get placed into the command. A quick fix for 0.8.8 folks may be
> as simple as removing/altering that logging statement.
>
> From what I can see, the current master does not include that logging
> statement, and thus should not be affected by the issue - it was removed in
> 4b9db3e6<https://github.com/buildbot/buildbot/commit/4b9db3e64a47985675a2975bb8348a4bcbaf08b3> which
> was fixing an entirely different bug but apparently had the side effect of
> also fixing this.
>
>
> On Mon, Nov 4, 2013 at 8:51 AM, Dustin J. Mitchell <dustin at v.igoro.us>wrote:
>
>> Can you file a bug with the full traceback?  I'm not sure what's not
>> being rendered from the chunk of the traceback you posted.
>>
>> Dustin
>>
>>
>> ------------------------------------------------------------------------------
>> Android is increasing in popularity, but the open development platform
>> that
>> developers love is also attractive to malware creators. Download this
>> white
>> paper to learn more about secure code signing practices that can help keep
>> Android apps secure.
>>
>> http://pubads.g.doubleclick.net/gampad/clk?id=65839951&iu=/4140/ostg.clktrk
>> _______________________________________________
>> Buildbot-devel mailing list
>> Buildbot-devel at lists.sourceforge.net
>> https://lists.sourceforge.net/lists/listinfo/buildbot-devel
>>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://buildbot.net/pipermail/devel/attachments/20131104/00028a94/attachment.html>