[Buildbot-devel] Use of Interpolate in git source step

Amber Yust amber.yust at gmail.com
Tue Nov 5 05:08:38 UTC 2013

Dustin, the issue is being triggered here:

The proximate cause of the problem is that the implementation of the Git
source step in 0.8.8 assumes that the command is a list of basic strings
such that they can be .join()'d together for a log message. This of course
fails if the command includes any Interpolate or WithProperties instances.

As far as I can tell, this has been a problem since 2011 when the rewritten
Git source step was introduced; that line blames all the way to
and would definitely prevent any non-string values in the parameters which
eventually get placed into the command. A quick fix for 0.8.8 folks may be
as simple as removing/altering that logging statement.

>From what I can see, the current master does not include that logging
statement, and thus should not be affected by the issue - it was removed in
was fixing an entirely different bug but apparently had the side effect of
also fixing this.

On Mon, Nov 4, 2013 at 8:51 AM, Dustin J. Mitchell <dustin at v.igoro.us>wrote:

> Can you file a bug with the full traceback?  I'm not sure what's not
> being rendered from the chunk of the traceback you posted.
> Dustin
> ------------------------------------------------------------------------------
> Android is increasing in popularity, but the open development platform that
> developers love is also attractive to malware creators. Download this white
> paper to learn more about secure code signing practices that can help keep
> Android apps secure.
> http://pubads.g.doubleclick.net/gampad/clk?id=65839951&iu=/4140/ostg.clktrk
> _______________________________________________
> Buildbot-devel mailing list
> Buildbot-devel at lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/buildbot-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://buildbot.net/pipermail/devel/attachments/20131104/a7bc6bc5/attachment.html>

More information about the devel mailing list