[Buildbot-devel] Trouble wiring up a web hook change source.

[Dustin J. Mitchell]

On Sat, Jun 8, 2013 at 6:21 PM, Benjamin Andre <bandre at lbl.gov> wrote:
> Sorry, that wasn't a diff from buildbot. It was the change I had to make
> to the change filter in my master.cfg.
>
> If I'm reading the doc correctly, branch=None should still work on the
> SingleBranchScheduler, but branch is depreciated in favor of
> ChangeFilters, and branch=None should work there as well....
>
> http://docs.buildbot.net/latest/full.html#change-filters
>
> http://docs.buildbot.net/latest/full.html#singlebranchscheduler
>
> I'm still learning, so it's possible (likely) that I have a different
> problem in my master.cfg, and this is making it work for the wrong reasons.

In general, relying on branch=None to magically translate to the
"normal" branch (trunk on svn, master on git, default on hg) is
fraught with peril, because things like schedulers and ChangeFilters
don't have a clue about the particulars of VC engines.  So we're
trying to get to the point of always producing a branch name, and just
dealing with it explicitly.  So branch="default" is a best practice
anyway.

I'm not sure I can tell what or how the version bump broke this for
you, but if it's fixed, it's fixed..

Dustin