[Buildbot-devel] Trouble wiring up a web hook change source.

[Benjamin Andre]

Sorry, that wasn't a diff from buildbot. It was the change I had to make 
to the change filter in my master.cfg.

If I'm reading the doc correctly, branch=None should still work on the 
SingleBranchScheduler, but branch is depreciated in favor of 
ChangeFilters, and branch=None should work there as well....

http://docs.buildbot.net/latest/full.html#change-filters

http://docs.buildbot.net/latest/full.html#singlebranchscheduler

I'm still learning, so it's possible (likely) that I have a different 
problem in my master.cfg, and this is making it work for the wrong reasons.

Ben


On 6/8/13 12:28 PM, Dustin J. Mitchell wrote:
> On Fri, Jun 7, 2013 at 10:21 PM, Benjamin Andre <bandre at lbl.gov> wrote:
>> Thanks for the suggestions. I was able to trace through the log back
>> to master.addChange() and it looked ok.
>> Trying a poller change source also failed. After that I traced it back
>> to the change filter. It looks like
>>
>> 0.8.7p1 :
>> my_filter = ChangeFilter(branch = None)
>>
>> git-development:
>> my_filter = ChangeFilter(branch = "default")
>>
>> I don't see anything in the doc to suggest that this needed to be
>> updated, so I'm not sure if it was an undocumented feature, a bug, or
>> another mistake on my part.
>
> Where are you seeing that diff?
>
> Dustin
>