[Buildbot-devel] graceful shutdown of ChangeSource sevices

[Jorge Gonzalez]

Fantastic. Thanks, that patch seems to work on 0.8.6!


Jorge


On Thu, Jun 6, 2013 at 7:50 PM, Dustin J. Mitchell <dustin at v.igoro.us>wrote:

> I was thinking of different work of Jared's, which is only on the nine
> branch.
>
> I think what fixed the failure to call stopService was
>
> commit dc3b3356d1400b8ab84a5e1e4abee55c3e67d408
> Author: Dustin J. Mitchell <dustin at mozilla.com>
> Date:   Sun Nov 4 11:30:25 2012 -0500
>
>     Test full-fledged master startup and shutdown.
>
>     This tests that the master basically works, and that the shutdown
>     process stops any outstanding timers, etc.  By running the master
> twice,
>     it also ensures that any stopService state cleanup occurs.
>
>     It turns out there were a few places where listeners were not being
>     released properly, deferreds not handled, etc.; fixes for those are
>     included here.
>
>     This also adds __repr__'s to pbmanager.py; they were useful in
> debugging
>     and don't hurt!
>
> As for poll not getting called -- my only guesses are that either
> you're not waiting long enough (IIRC the first poll does not occur
> immediately), or something's interfering with the startService
> execution in PollingChangeSource.
>
> Dustin
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://buildbot.net/pipermail/devel/attachments/20130606/ffe99b64/attachment.html>