[Buildbot-devel] bzr_buildbot.py not working

[Dustin J. Mitchell]

On Tue, Sep 11, 2012 at 2:29 PM, David Engster <deng at randomsample.de> wrote:
> Is this a bug or am I doing something wrong?

It's a bug - in fact, related to a very old one,
http://trac.buildbot.net/ticket/708

Because the poller is in contrib (due, among other things, to
licensing restrictions), it is not well-tested and tends to fall out
of sync.

In this case, the problem is that revision must be a string.  Can you
try this fix?

diff --git a/master/contrib/bzr_buildbot.py b/master/contrib/bzr_buildbot.py
index 5f84fb9..91af9bf 100644
--- a/master/contrib/bzr_buildbot.py
+++ b/master/contrib/bzr_buildbot.py
@@ -267,9 +267,12 @@ if DEFINE_POLLER:
                     twisted.python.log.err()
                 else:
                     for change in changes:
+                        last_revision = change['revision']
+                        # make revision a string, as buildbot requires
+                        change['revision'] = str(change['revision'])
                         yield self.addChange(
                             buildbot.changes.changes.Change(**change))
-                        self.last_revision = change['revision']
+                        self.last_revision = last_revision
             finally:
                 self.polling = False


Dustin