[Buildbot-devel] AttributeError on LRUCache with Blocker step on buildbot 0.8.7

[Tom Prince]

"Dustin J. Mitchell" <dustin at v.igoro.us> writes:

> Hmm, blocker really shouldn't be peeking into private data like that.
>
> You must have upgraded from a few versions back - neither Blocker
> (which is essentially unmaintained and untested at this point) nor the
> LRU cache are new.

Given that this code is untested, undocumented and broken, I'm inclined
to remove it.

I'm not sure how Blocker is intended to be used. My initial thought is
that this could be replaced by locks, or something like them.

Some searching found
http://permalink.gmane.org/gmane.comp.python.buildbot.devel/8158
and the situation described there sounds like it would be better solved
by using Trigger steps. (Or some suitably extended version of that, now
that Trigger can target any scheduler with the right interface)

  Tom