[Buildbot-devel] AttributeError on LRUCache with Blocker step on buildbot 0.8.7

[Dustin J. Mitchell]

Hmm, blocker really shouldn't be peeking into private data like that.

You must have upgraded from a few versions back - neither Blocker
(which is essentially unmaintained and untested at this point) nor the
LRU cache are new.

You'll see that the comments describe the failing line as "subtly
broken".  You might be able to fix it by only using
builderStatus.getCurrentBuilds() there.

Dustin

On Thu, Oct 11, 2012 at 5:05 AM, Boris Savelev <boris.savelev at gmail.com> wrote:
> Hello!
>
> Just upgrade up to 0.8.7 and get error on one of my custom step:
> {{{
> Traceback (most recent call last):
>   File "/usr/lib/python2.6/dist-packages/twisted/internet/defer.py",
> line 441, in _runCallbacks
>     self.result = callback(self.result, *args, **kw)
>   File "/usr/lib/python2.6/dist-packages/twisted/internet/defer.py",
> line 1014, in unwindGenerator
>     return _inlineCallbacks(None, f(*args, **kwargs), Deferred())
>   File "/usr/lib/python2.6/dist-packages/twisted/internet/defer.py",
> line 893, in _inlineCallbacks
>     result = g.send(result)
>   File "/home/builder/venv/lib/python2.6/site-packages/buildbot/process/buildstep.py",
> line 600, in _startStep_3
>     result = yield defer.maybeDeferred(self.start)
> --- <exception caught here> ---
>   File "/usr/lib/python2.6/dist-packages/twisted/internet/defer.py",
> line 125, in maybeDeferred
>     result = f(*args, **kw)
>   File "/home/builder/cis/buildbot/hacks.py", line 172, in start
>     r = buildbot.steps.blocker.Blocker.start(self)
>   File "/home/builder/venv/lib/python2.6/site-packages/buildbot/steps/blocker.py",
> line 212, in start
>     buildStatus = self._getBuildStatus(botmaster, builderName)
>   File "/home/builder/cis/buildbot/hacks.py", line 159, in _getBuildStatus
>     r = buildbot.steps.blocker.Blocker._getBuildStatus(self,
> botmaster, builderName)
>   File "/home/builder/venv/lib/python2.6/site-packages/buildbot/steps/blocker.py",
> line 141, in _getBuildStatus
>     all_builds = (builderStatus.buildCache.values() +
> exceptions.AttributeError: 'LRUCache' object has no attribute 'values'
> }}}
>
> step class code: http://pastebin.com/A7i4F9EK
> using step code: http://pastebin.com/VYMfxdC0
>
> --
> Boris
>
> ------------------------------------------------------------------------------
> Don't let slow site performance ruin your business. Deploy New Relic APM
> Deploy New Relic app performance management and know exactly
> what is happening inside your Ruby, Python, PHP, Java, and .NET app
> Try New Relic at no cost today and get our sweet Data Nerd shirt too!
> http://p.sf.net/sfu/newrelic-dev2dev
> _______________________________________________
> Buildbot-devel mailing list
> Buildbot-devel at lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/buildbot-devel