[Buildbot-devel] CVSMailDir buglet

[Dustin J. Mitchell]

I merged this to the buildbot-0.8.7 branch.  Thanks!

Dustin

On Fri, Oct 12, 2012 at 7:35 PM, Andy Howell <andy at gamubaru.com> wrote:
> Hello,
>
>         I'm upgrading to 0.8.7 from 0.8.4. I use the CVSMailDir change
> source. After the upgrade I got the traceback below. CVSMailDir is passing
> back a keyword variable called 'links', which is no longer supported. The
> attached patch fixes it by removing the argument.
>
> 2012-10-12 16:59:52-0500 [-] Unhandled Error
>         Traceback (most recent call last):
>           File
> "/usr/lib/python2.7/site-packages/buildbot-0.8.7-py2.7.egg/buildbot/util/maildir.py",
> line 110, in poll
>             yield self.messageReceived(n)
>           File
> "/usr/lib/python2.7/site-packages/buildbot-0.8.7-py2.7.egg/buildbot/changes/mail.py",
> line 66, in messageReceived
>             d.addCallback(add_change)
>           File "/usr/lib/python2.7/site-packages/twisted/internet/defer.py",
> line 260, in addCallback
>             callbackKeywords=kw)
>           File "/usr/lib/python2.7/site-packages/twisted/internet/defer.py",
> line 249, in addCallbacks
>             self._runCallbacks()
>         --- <exception caught here> ---
>           File "/usr/lib/python2.7/site-packages/twisted/internet/defer.py",
> line 441, in _runCallbacks
>             self.result = callback(self.result, *args, **kw)
>           File
> "/usr/lib/python2.7/site-packages/buildbot-0.8.7-py2.7.egg/buildbot/changes/mail.py",
> line 63, in add_change
>             return self.master.addChange(src=src, **chdict)
>         exceptions.TypeError: addChange() got an unexpected keyword argument
> 'links'
>
> Regards,
>
>         Andy
>
> ------------------------------------------------------------------------------
> Don't let slow site performance ruin your business. Deploy New Relic APM
> Deploy New Relic app performance management and know exactly
> what is happening inside your Ruby, Python, PHP, Java, and .NET app
> Try New Relic at no cost today and get our sweet Data Nerd shirt too!
> http://p.sf.net/sfu/newrelic-dev2dev
> _______________________________________________
> Buildbot-devel mailing list
> Buildbot-devel at lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/buildbot-devel
>