[Buildbot-devel] CVSMailDir buglet

[Andy Howell]

Hello,

	I'm upgrading to 0.8.7 from 0.8.4. I use the CVSMailDir change source. After the upgrade 
I got the traceback below. CVSMailDir is passing back a keyword variable called 'links', 
which is no longer supported. The attached patch fixes it by removing the argument.

2012-10-12 16:59:52-0500 [-] Unhandled Error
         Traceback (most recent call last):
           File 
"/usr/lib/python2.7/site-packages/buildbot-0.8.7-py2.7.egg/buildbot/util/maildir.py", line 
110, in poll
             yield self.messageReceived(n)
           File 
"/usr/lib/python2.7/site-packages/buildbot-0.8.7-py2.7.egg/buildbot/changes/mail.py", line 
66, in messageReceived
             d.addCallback(add_change)
           File "/usr/lib/python2.7/site-packages/twisted/internet/defer.py", line 260, in 
addCallback
             callbackKeywords=kw)
           File "/usr/lib/python2.7/site-packages/twisted/internet/defer.py", line 249, in 
addCallbacks
             self._runCallbacks()
         --- <exception caught here> ---
           File "/usr/lib/python2.7/site-packages/twisted/internet/defer.py", line 441, in 
_runCallbacks
             self.result = callback(self.result, *args, **kw)
           File 
"/usr/lib/python2.7/site-packages/buildbot-0.8.7-py2.7.egg/buildbot/changes/mail.py", line 
63, in add_change
             return self.master.addChange(src=src, **chdict)
         exceptions.TypeError: addChange() got an unexpected keyword argument 'links'

Regards,

	Andy
-------------- next part --------------
A non-text attachment was scrubbed...
Name: bb_cvsmaildir.patch
Type: text/x-patch
Size: 1306 bytes
Desc: not available
URL: <http://buildbot.net/pipermail/devel/attachments/20121012/6959cf10/attachment.bin>