[Buildbot-devel] How to check doStepIf before locks

[Tom Prince]

Thomas Middeldorp <thomas at ranzer.geek.nz> writes:

> Hi,
>
> I'm having a problem with my builder setup where builders keep blocking 
> each other when they don't need to because the buildstep 'locks' param 
> gets evaluated before the 'doStepIf' param. Is there any way to change 
> this behaviour so that doStepIf gets evaluated before trying to aquire 
> locks? Or does anyone know of a work around for this sort of problem?

The only way to change this behavior is to modify the code in
BuildStep.startStep and related methods. (Incidently, the sane way to do
this would also cause doStepIf to be evaluated before renderables). It
wouldn't be too hard to do, and seems mostly sensible. Although, if
somebody where relying on the slave-lock being held in the doStepIf,
there code would break. I suspect, though, that the ability to return
deferred's from a doStepIf is little know or used, though.

  Tom