[Buildbot-devel] Adding interpolated property in a build step

Tom Prince tom.prince at ualberta.net
Tue Aug 28 05:12:00 UTC 2012


Alexander Sack <pisymbol at gmail.com> writes:

> 8 class SetBuildProperty(BuildStep):
> ....
>
> I really believe this should be added as a core
> feature of ANY BuildStep (minimally the above should be part of the
> base).

Certainly the above step seems like a useful addtion to buildbot. Feel
free to submit it as a patch (along with docs+tests). It should probably
also log the properties it is setting and the values it is setting them to.

I'm not sure if it would be a good thing to have as an feature of every
buildstep. I think it would probably be somewhat confusing to have
random buildsteps altering the properties, rather than having explicit
steps do that (unless the propertry is related to the run of the step,
but then the above code wouldn't handle that.

  Tom




More information about the devel mailing list