[Buildbot-devel] environment during source steps

[Tom Prince]

Jorge Gonzalez <gjorge at google.com> writes:

> The latest documentation [1] claims that source steps take an 'env'
> argument whose contents should be added to child commands' environment.

The documentation you are pointing to is only for the new master-side steps.

The slave side steps are documented at:
http://buildbot.net/buildbot/docs/latest/full.html#source-checkout-slave-side


> I just uploaded a partial change [2] that adjusts this just for the Repo
> step.

While I'd be willing to accept changes to the slave-side steps that
don't have master-side counterparts, I'd much prefer to see master-side
steps created for any vcs that people are actively using.

The most significant reason for this, (given a new enough slave that it
supports the master-side steps), fixes to the source steps like this can
be done simply by upgrading the master, without require changes to the
(often many more) slaves.

  Tom