[Buildbot-devel] environment during source steps

[Jorge Gonzalez]

The latest documentation [1] claims that source steps take an 'env'
argument whose contents should be added to child commands' environment.

Yet, this is not happening for, e.g., the Repo command. And as far I can
tell from looking at the slave-side code, it is the case for all other
source steps. In particular, all source step implementations seem to rely
on SourceBaseCommand.getCommand()<https://github.com/buildbot/buildbot/blob/master/slave/buildslave/commands/base.py#L261>
to
locate the commands they need.
Any reason not to rely on the same mechanism that *ShellCommand*s rely on?
It seems convenient and reasonable to have the same kind of control over
source steps...

I just uploaded a partial change [2] that adjusts this just for the Repo
step
Before broadening it to other steps and offering it upstream, I'd like to
know the rationale behind the current implementation or others' opinion on
my idea.

[1]
http://buildbot.net/buildbot/docs/latest/full.html#module-buildbot.steps.source
[2]
https://github.com/jgonzalezmendez/buildbot/tree/et_env_SourceBaseCommand

Thanks,
Jorge
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://buildbot.net/pipermail/devel/attachments/20120823/60d2a6ac/attachment.html>