[Buildbot-devel] env dict passed to Source steps ignored in buildslaves?

[Jorge Gonzalez]

On Tue, Apr 24, 2012 at 10:12 PM, Tom Prince <tom.prince at ualberta.net>wrote:

> On Tue, 24 Apr 2012 09:38:57 -0700, Jorge Gonzalez <gjorge at google.com>
> wrote:
> > Hi list,
> > I was just trying to set up the PATH env variable for a source step, but
> it
> > didn't seem to have an effect at runtime, based on what the logs showed.
>
> What specific step are you using?
>
Repo

>
> > Correct me if I'm wrong, but it seems to me like the env dictionary
> passed
> > to subclasses of buildbot.steps.source.oldsource.Source is being ignored
> on
> > the slave-side's buildslave.commands.base.SourceBaseCommand.setup(). In
> > particular, it's doing "self.env = os.environ.copy()" and completely
> > ignoring what was passed to it.
>
> This looks like it is the case.
>
> > Assuming this is what's causing my own env to be ignored, is there a good
> > reason for this?
>
> There is a reason. The argument was added and implemented for the
> master-side steps, which share the baseclass with the slave-side
> steps. The feature was never added to the slave-side steps.
>
>  Tom
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://buildbot.net/pipermail/devel/attachments/20120425/6079bb7a/attachment.html>