[Buildbot-devel] Behavior expected from SVN master side source step

[Charles Lepple]

On Apr 1, 2012, at 12:18 PM, Dustin J. Mitchell wrote:

> On Sat, Mar 31, 2012 at 1:34 PM, Saurabh Kumar <saurabhgeek92 at gmail.com> wrote:
>> I discussed this issue with Tom, and both of us have not used SVN much,
>> so this new behavior may miss out on corner cases, or may not be what
>> users expect from repourl, especially if they need branch information
>> from the source stamp ignored. Any feedback from SVN users would be helpful.
> 
> I would very much like to hear back from people here, too!
> 
> In https://github.com/buildbot/buildbot/pull/371 Callek suggested
> using WithProperties or Interpolate, rather than doing magic string
> substitutions.  I *think* that this can cover all of the necessary
> cases, and more, and for all of the VC's, not just SVN.
> 
> However, this comes at the cost of backward compatibility for users of
> the *master-side* classes.  I suspect that's a rather small bunch of
> folks, since those have only been available in 0.8.5 and 0.8.6, so if
> we provided sufficient assistance for upgrading, I think we could get
> away with the compatibility break.


I'll be honest, when I upgraded to 0.8.5, I didn't see much of an advantage of moving to the master-side classes for SVN ("if it ain't broke..."), especially since the code I'm building is eventually moving from Subversion to Git. So I'm probably not part of the target audience, but I do think that it might be good to standardize on something like WithProperties.

For what it's worth, I usually end up including a custom split_file_branches() function for the change source that returns the text 'trunk' instead of None for the default branch, so I might not be seeing all of the potential problems that might arise from using WithProperties. Also, this means we have to explicitly specify 'branches/foo' instead of just 'foo' in the force build page for NUT - not sure how other people are handling that in their Subversion+Buildbot setup, but it Works For Me (tm).

-- 
Charles Lepple
clepple at gmail