[Buildbot-devel] Behavior expected from SVN master side source step
Dustin J. Mitchell
dustin at v.igoro.us
Sun Apr 1 16:18:20 UTC 2012
On Sat, Mar 31, 2012 at 1:34 PM, Saurabh Kumar <saurabhgeek92 at gmail.com> wrote:
> I discussed this issue with Tom, and both of us have not used SVN much,
> so this new behavior may miss out on corner cases, or may not be what
> users expect from repourl, especially if they need branch information
> from the source stamp ignored. Any feedback from SVN users would be helpful.
I would very much like to hear back from people here, too!
In https://github.com/buildbot/buildbot/pull/371 Callek suggested
using WithProperties or Interpolate, rather than doing magic string
substitutions. I *think* that this can cover all of the necessary
cases, and more, and for all of the VC's, not just SVN.
However, this comes at the cost of backward compatibility for users of
the *master-side* classes. I suspect that's a rather small bunch of
folks, since those have only been available in 0.8.5 and 0.8.6, so if
we provided sufficient assistance for upgrading, I think we could get
away with the compatibility break.
More information about the devel