[Buildbot-devel] [RFC] enhancements to buildbots repo/gerrit support

[Pierre Tardy]

On Thu, Jun 30, 2011 at 9:53 AM, Pierre Tardy <tardyp at gmail.com> wrote:

>
> On Thu, Jun 30, 2011 at 6:47 AM, Dustin J. Mitchell <dustin at v.igoro.us>wrote:
>
>> On Fri, Jun 17, 2011 at 11:30 PM, Dustin J. Mitchell <dustin at v.igoro.us>
>> wrote:
>> > If Pierre's work can be implemented in such a way that it safely
>> > disables itself on older Twisteds, then the increased version
>> > requirement would not prevent me from merging it.
>>
>> Where are things on this process?  I was quite pleased to see others
>> chipping in reviewing and responding - many hands make light work -
>> but don't want it to get dropped!
>>
>> As I responded on
>>   https://github.com/buildbot/buildbot/pull/154
>> it looks like some of this is ready to merge, while some is still a
>> bit experimental.  I'd love to get the mergeable bits merged.
>>
>
> Yeah, I got a bit busy those weeks, sorry. I have some more fixes on the
> pipe, I need to squash them, and reorganize to make them more clear.
>
I updated my branch:

first patches are fixes (ready for merge):
0b30fe gerritchangesource: use gerrit's changeid as the branch
3f8623f status_gerrit: replace quotes by double quotes in message
98467ea Trigger: dont fail if copied property does not exist
32886a0 slave/repo: do repo sync twice
e57679f slave/repo: dont clobber if cherry-pick fails
ad586c2 slave/repo: reset the tree in case some cherry-picked failed before

Then you got some customizability patches (ready for merge):
e6be01d status_gerrit: add global status in the callback    <-- this one
changes API
73f8c04 gerritchangesource: factorize to allow subclassing
2b9d699 repo_source: added buildDownloadList method

Then there is a RFC only patch, not for merge.
4fa04d3 [RFC] Simplify the forced build system

Pierre
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://buildbot.net/pipermail/devel/attachments/20110630/430fab16/attachment.html>