[Buildbot-devel] [RFC] enhancements to buildbots repo/gerrit support

[Aurelien Bompard]

Hey there,

I've modified GerritStatusPush to act on sourcestamp completion only :
https://github.com/abompard/buildbot/commit/d739baabdc307af5e4f544a5e0d40a39bc32ce56

It works fine with my install (Gerrit + Git) but I did not test it with 
Gerrit + repo.

The process we currently have is :
 1. GerritChangeSource listens to events
 2. Gerrit pushes an event
 3. It goes through the schedulers and causes a number of builds to run
 4. Every build's status is pushed back to Gerrit in the order they are
    completed, overwriting the change's status in Gerrit as they go.

With my change, step 4 is replaced by:
 4. Only the global status of the change is pushed back to Gerrit by
    GerritStatusPush

It feels much nicer. Could someone with a Gerrit+repo setup test it, or 
shoud I just go ahead and submit a merge request ?


Aurélien
-- 
http://aurelien.bompard.org    ~~~~~~    jabber: aurelien at bompard.org
"Normal people [...] believe that if it ain't broke, don't fix it.
Engineers believe that if it ain't broke, it doesn't have enough
features yet." -- Scott Adams